Change: Use XML file iterator for CVE updates #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update of the CVEs now also uses the XML file iterator instead of loading and parsing the whole file. Also, a memory leak in insert_cve_products has been fixed. This reduces the amount of memory used during the update.
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
reviewed
Mar 6, 2024
|
@bjoernricks This uses the same version of gvm-libs as #2142 and I've raised the version requirement there. |
nice! just wanted to be sure :-) |
a-h-abdelsalam
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The update of the CVEs now also uses the XML file iterator instead of loading and parsing the whole file.
Also, a memory leak in insert_cve_products has been fixed.
Why
This reduces the amount of memory used during the update.
References
GEA-498