Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Replace CPE xml_split with XML iterator #2142

Merged
merged 5 commits into from
Mar 6, 2024

Commits on Mar 1, 2024

  1. Change: Replace CPE xml_split with XML iterator

    When updating the CPEs, the CPE dictionary file is no longer split
    into separate temporary files. Instead a new XML file iterator added to
    gvm-libs is used to avoid creating the DOM of the whole file.
    Also, the buffered insert statements are now also run when a size
    threshold configurable via a setting is reached.
    
    This removes the dependency on the xml_split script, avoids problems
    with the temp split XML files being left behind in case of crashes and
    gives more control over the memory usage of the CPEs update.
    timopollmeier committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7eeeb08 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Address review comments for new XML file iterator

    The error handling is improved by freeing the iterator on errors,
    consistently jumping to the failure handling and handling cases
    where (re-)initalizing the parser context fails.
    Also the limit for the threshold is now always applied.
    timopollmeier committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    165ad22 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    4b8a9e2 View commit details
    Browse the repository at this point in the history
  2. Remove: Remove xml_split / xml-twig-tools dependency

    This optional dependency is no longer needed with the new XML file
    iterator.
    timopollmeier committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b6e6947 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    67a85d5 View commit details
    Browse the repository at this point in the history