Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-1778:comment ACL call and add debug message #3203

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

NET-1778:comment ACL call and add debug message #3203

wants to merge 17 commits into from

Conversation

yabinma
Copy link
Collaborator

@yabinma yabinma commented Nov 12, 2024

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 Awaiting requested review from abhishek9686

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yabinma @abhishek9686