Alternative approach for findSchemaChanges #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
reviewed
Oct 14, 2024
JoviDeCroock
force-pushed
the
find-schema-changes
branch
from
6d72220
to
d4a1114
Compare
yaacovCR
reviewed
Oct 14, 2024
|
Converting to draft so I can add |
yaacovCR
approved these changes
Oct 14, 2024
JoviDeCroock
force-pushed
the
find-schema-changes
branch
2 times, most recently
from
afcd663
to
d775140
Compare
JoviDeCroock
force-pushed
the
find-schema-changes
branch
from
d775140
to
0670f3d
Compare
yaacovCR
reviewed
Oct 14, 2024
yaacovCR
reviewed
Oct 14, 2024
yaacovCR
approved these changes
Oct 14, 2024
JoviDeCroock
force-pushed
the
find-schema-changes
branch
from
0670f3d
to
4c059f6
Compare
|
I do not use this method and have no particular opinion on it, so (due to lack of time) I'm going to decline to review it. Perhaps you can find someone who relies on this functionality to review it - maybe The Guild could help here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2181
This adds a new
findSchemaChangesexport and deprecates the breaking and dangerous alternative to be removed in v18. While adding safe-schema-changes I noticed that we lack directive arg validation here, we should probably add these to breaking/dangerous changes in the future.