Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase PeerDAS onto electra #55

Draft
wants to merge 63 commits into
base: develop
Choose a base branch
from

Conversation

hangleang
Copy link
Contributor

this pull request will rebase the functionality of PeerDAS onto electra fork, this final update should express the current status of the implementation. this will be ready for review once these following PRs in other parts of the codebase merged into the upstream branch, then I will link the submodules to those commits:

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ Tumas
✅ hangleang
❌ povi
❌ weekday-grandine-io
You have signed the CLA already but the status is still pending? Let us recheck it.

Mdominykas and others added 27 commits November 28, 2024 14:46
WARNING: EIP-7594 contains a new preset variable with a name nearly identical to an older one.
Compare:
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH  added in Deneb.
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH added in EIP-7594.

Also note that neither variable is independent.
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH is derived from MAX_BLOB_COMMITMENTS_PER_BLOCK.
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH is effectively a constant.
Tumas and others added 28 commits November 28, 2024 14:51
fix(wip): resolved conflicts after rebase

fix(wip): resolved code conflicted

fix: failed kzg_commitment_inclusion_proof tests and remove usued imports

fix: subscribe data column subnets if eip7594 scheduled

fix: kzg_inclusion_proofs in deneb and electra

fix: validate block with DA checking

update snapshot-tests, eth2_libp2p

fix: missing check in spec test

chore: sort custody subnets

fix: reconstruction runtime error

update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants