-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase PeerDAS onto electra #55
Draft
hangleang
wants to merge
63
commits into
grandinetech:develop
Choose a base branch
from
hangleang:rebase-peerdas
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING: EIP-7594 contains a new preset variable with a name nearly identical to an older one. Compare: KZG_COMMITMENT_INCLUSION_PROOF_DEPTH added in Deneb. KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH added in EIP-7594. Also note that neither variable is independent. KZG_COMMITMENT_INCLUSION_PROOF_DEPTH is derived from MAX_BLOB_COMMITMENTS_PER_BLOCK. KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH is effectively a constant.
…a column sidecar's inclusion proof
fix(wip): resolved conflicts after rebase fix(wip): resolved code conflicted fix: failed kzg_commitment_inclusion_proof tests and remove usued imports fix: subscribe data column subnets if eip7594 scheduled fix: kzg_inclusion_proofs in deneb and electra fix: validate block with DA checking update snapshot-tests, eth2_libp2p fix: missing check in spec test chore: sort custody subnets fix: reconstruction runtime error update
hangleang
force-pushed
the
rebase-peerdas
branch
from
November 28, 2024 12:15
31b3e37
to
4a957b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request will rebase the functionality of PeerDAS onto
electra
fork, this final update should express the current status of the implementation. this will be ready for review once these following PRs in other parts of the codebase merged into the upstream branch, then I will link the submodules to those commits: