Add minimum Java version so the grails forge cli can pull that property instead of defaulting based on its own version #13877
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty instead of defaulting based on its own version
|
I have an associated 7.0.0 branch here: jdaugherty:feature/7.0.0/pomJavaVersion |
|
Closing this, we're going to default the version in the cli instead. |
|
@jdaugherty couldn't you have just pulled this from spring? The spring-bom is imported using the grails-gradle-plugin and I am pretty sure spring has a parent pom with this same information |
|
Probably but we don't really need to make it that complicated because either way we have to update the JdkVersion enum in the cli project and there was already a placeholder for the default |
|
actually, that wouldn't have worked because Spring went from 8 > 17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.