asyncQueryDataSupport: always run queries asynchronously #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
iwysiu and
sarahzinger
and removed request for
a team
sarahzinger
reviewed
Mar 12, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## v0.2.0 | |||
There was a problem hiding this comment.
is this considered a breaking change do we think? If so does that mean we move to 1.0.0? I feel like @iwysiu probably knows semver better than me haha.
There was a problem hiding this comment.
v0 s are pre-release development versions, so we don't need to bump it. A 1.0.0 would be when we cut the first actual release!
sarahzinger
approved these changes
Mar 12, 2024
iwysiu
approved these changes
Mar 12, 2024
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## v0.2.0 | |||
There was a problem hiding this comment.
v0 s are pre-release development versions, so we don't need to bump it. A 1.0.0 would be when we cut the first actual release!
It should be ok, I symlinked it and tested it locally with the feature toggle on and off, and both make async requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of grafana/grafana#66277 and grafana/grafana#66276
Removes part of the code that conditionally ran async queries. This makes it so that queries always run async
Athena draft: grafana/athena-datasource#316