Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated internal Test.getClassLoaderCache() #60

Merged
merged 13 commits into from
Aug 4, 2020
Merged

Replace deprecated internal Test.getClassLoaderCache() #60

merged 13 commits into from
Aug 4, 2020

Conversation

jonnybbb
Copy link
Member

@jonnybbb jonnybbb commented Aug 2, 2020 •
edited
Loading

Fixes #53

Checklist:

@jonnybbb jonnybbb marked this pull request as draft August 2, 2020 20:53
@jonnybbb jonnybbb self-assigned this Aug 3, 2020
@jonnybbb jonnybbb force-pushed the jonnybbb/53_replaceClassLoaderCache branch from 9d428db to dea1511 Compare August 3, 2020 18:40
@jonnybbb jonnybbb mentioned this pull request Aug 3, 2020
Closed
@jonnybbb jonnybbb force-pushed the jonnybbb/53_replaceClassLoaderCache branch from f91a3fe to 7d4b972 Compare August 3, 2020 20:55
@jonnybbb jonnybbb marked this pull request as ready for review August 3, 2020 21:36
jonnybbb and others added 8 commits August 4, 2020 10:46
@jonnybbb
replace deprecated Internal Test.getClassLoaderCache() by getting the…
db0f301 
… service from the internal project

Signed-off-by: Johannes Bühler <[email protected]>

#53
@jonnybbb
update to gradle 6.6-rc-4 to be prepared for gradle 6.6 compatibility
539fcb4 
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb
provide backwards compatibility for GBT versions < 6.6
af13a86 
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb
update to latest gradle rc5
8fb6cbe 
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb @marcphilipp
get class name directly
31479ef 
Co-authored-by: Marc Philipp <[email protected]>
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb @marcphilipp
simplified gradle version comparison
4cbcbe0 
Co-authored-by: Marc Philipp <[email protected]>
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb
applied review feedback
ca306d4 
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb
supress warning for constructor only available in older versions
1b48b3b 
Signed-off-by: Johannes Bühler <[email protected]>
@jonnybbb jonnybbb force-pushed the jonnybbb/53_replaceClassLoaderCache branch from 300a07e to 1b48b3b Compare August 4, 2020 08:46
marcphilipp
marcphilipp suggested changes Aug 4, 2020
View reviewed changes
sample-tests/build.gradle.kts Show resolved Hide resolved
sample-tests/build.gradle.kts Outdated Show resolved Hide resolved
@jonnybbb jonnybbb merged commit 312965e into master Aug 4, 2020
@jonnybbb jonnybbb deleted the jonnybbb/53_replaceClassLoaderCache branch August 4, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees

@jonnybbb jonnybbb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal Test.getClassLoaderCache() deprecated in 6.6, will be removed in 7.0
2 participants
@jonnybbb @marcphilipp