Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the installation command #753

Closed
wants to merge 1 commit into from

Conversation

GauravRajwada
Copy link

Updated the installation command with the latest one.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (976b536) to head (3608043).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files           5        5           
  Lines         911      911           
=======================================
  Hits          725      725           
  Misses        131      131           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

```sh
go get -u github.com/gorilla/mux
go install github.com/gorilla/mux@latest
Copy link

@jackgris jackgris Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, maybe the command should be go get -u github.com/gorilla/mux@latest ???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - I'm in favor of staying with go get over go install here.

Copy link

@ghost ghost May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauravRajwada The go install command is not appropriate here. The command fails with the error package github.com/gorilla/mux is not a main package.

The documentation is correct as is. @AlexVulaj this PR should be rejected.

@jaitaiwan
Copy link
Member

Change to install is not correct. Closing

@jaitaiwan jaitaiwan closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants