Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that event file could not be written #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrMYHuang
Copy link

@MrMYHuang MrMYHuang commented Jan 23, 2018

Without train_writer.close(), event file could not be written to disk. It might be race condition of program ending and event file writing. Actually, if I run this script step by step by python debugger, event file can be correctly written to disk. But it fails, if I run the the script by "python -m" in terminal.

Without train_writer.close(), event file could not be written. It might be race condition of program ending and event file writing. Actually, if I run this script step by step by python debugger, event file can be correctly written to disk. But it fails, if I run the the script by "python -m" in terminal.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@MrMYHuang
Copy link
Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants