Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SERVER_TIMESTAMP should survive deep copies (#820) #821

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feat: SERVER_TIMESTAMP should survive deep copies (#820) #821

merged 1 commit into from
Dec 13, 2023

Conversation

mgraczyk
Copy link
Contributor

@mgraczyk mgraczyk commented Dec 12, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #820

Please let me know if you expect additional tests.

@mgraczyk mgraczyk requested review from a team as code owners December 12, 2023 00:54
@google-cla Google CLA
Copy link

google-cla bot commented Dec 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/python-firestore API. labels Dec 12, 2023
@mgraczyk mgraczyk changed the title Add dunder copy and deepcopy to Sentinel feat: SERVER_TIMESTAMP should survive deep copies (#820) Dec 12, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2023
@mgraczyk
Copy link
Contributor Author

Fixed lint error with amend

daniel-sanche
daniel-sanche approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together!

@daniel-sanche
Copy link
Contributor

looks like you just need to pull in main

@mgraczyk
feat: SERVER_TIMESTAMP should survive deep copies (#820)
9c3902b 
* Add dunder copy and deepcopy to Sentinel
@mgraczyk
Copy link
Contributor Author

Updated on top of main

@daniel-sanche daniel-sanche added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@daniel-sanche daniel-sanche merged commit 2b17705 into googleapis:main Dec 13, 2023
20 checks passed
@release-please release-please bot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SERVER_TIMESTAMP should survive deep copies (dataclasses.asdict)
4 participants
@mgraczyk @daniel-sanche @parthea @yoshi-kokoro