-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow #716
Conversation
These will be deprecated starting in Python 3.12. Replaced: - `datetime.datetime.utcnow()` with `datetime.datetime.now(tz=datetime.timezone.utc)` - `datetime.utcfromtimestamp()` with `datetime.fromtimestamp(tz=datetime.timezone.utc)`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from what I can tell, except for the change to the public interface, which you'd know more about than me.
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I filed #812 for the issue |
These will be deprecated starting in Python 3.12.
Replaced:
datetime.datetime.utcnow()
withdatetime.datetime.now(tz=datetime.timezone.utc)
datetime.utcfromtimestamp()
withdatetime.fromtimestamp(tz=datetime.timezone.utc)
Source: python/cpython#103857
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
BEGIN_COMMIT_OVERRIDE
fix: Remove used of deprecated
datetime.datetime.utcnow()
anddatetime.utcfromtimestamp()
docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow
END_COMMIT_OVERRIDE