Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): fix defer call in for loop #11175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pubsub): fix defer call in for loop #11175

wants to merge 1 commit into from

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Nov 22, 2024

SSIA. Avoid the defer function call in for loop.

@zchee zchee requested review from shollyman and a team as code owners November 22, 2024 13:51
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Nov 22, 2024
@zchee
Copy link
Contributor Author

zchee commented Nov 22, 2024

/cc @hongalex

@zchee zchee changed the title pubsub: fix defer call in for loop fix(pubsub): fix defer call in for loop Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zchee