fix(spanner): do not mutate incoming options in createGCPMultiEndpoint #11151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nimf What is the issue this PR is fixing, can you also please add a failing test it will help me in understanding changes better. |
|
Sorry, this is a followup of this conversation: #9565 (comment) |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Thanks, is it possible to add failing test with current code? |
Yes, let me add that. |
|
@rahul2393 can you trigger the kokoro run, please? |
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
This is another test failing, not related to the changes. It passes locally, but fails in the kokoro env. I will investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.