Make fetch-gn and activate-emsdk optional in git-sync-deps #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
These two scripts is platform-dependent and may fail if there are no prebuilt binaries for an unsupported platform. Making these steps optional makes building on those platforms easier, for they can use their own versions of toolchain (e.g. packages in a Linux distro).
|
This PR (HEAD: 6969759) has been imported to Gerrit for code review. Please visit review.skia.org/765896 to see it. Please CC yourself to the Gerrit change. Note:
|
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Oct 14, 2023
De-vendor Skia dependencies by making `SKIA_USE_SYSTEM_LIBRARIES` actually working; to be upstreamed to Arch. Related upstream PRs (for now): - rust-skia/rust-skia#851 - rust-skia/rust-skia#852 - rust-skia/rust-skia#854 - google/skia#146
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Oct 14, 2023
De-vendor Skia dependencies by making `SKIA_USE_SYSTEM_LIBRARIES` actually working; to be upstreamed to Arch. Related upstream PRs (for now): - rust-skia/rust-skia#851 - rust-skia/rust-skia#852 - rust-skia/rust-skia#854 - google/skia#146
aimixsaka
added a commit
to aimixsaka/archriscv-packages
that referenced
this pull request
Dec 29, 2023
- Remove unneeded depends - Remove ring 0.16 patch as upstream updated to 0.17 - Bump `rust-skia` to self-forked `0.68.0` [1] to catch up upstream [2]. This fix: ``` warning: Patch `SOMETHING` was not used in the crate graph. Check that the patched package version and available features are compatible with the dependency requirements ``` - Backport rust-skia/rust-skia#916 to fix rust-skia/rust-skia#913 - Remaining relevant pr/issue: - google/skia#146 - https://gitlab.archlinux.org/archlinux/packaging/packages/neovide/-/issues/1 [1]: https://github.com/aimixsaka/rust-skia/tree/riscv-skia-bindings-0.68.0 [2]: https://github.com/neovide/neovide/blob/af9869bd6d8d3434b187e29f85032ee74e40b536/Cargo.toml#L59C68-L59C68
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Dec 29, 2023
- Remove unneeded depends - Remove ring 0.16 patch as upstream updated to 0.17 - Bump `rust-skia` to self-forked `0.68.0` [1] to catch up upstream [2]. This fix: ``` warning: Patch `SOMETHING` was not used in the crate graph. Check that the patched package version and available features are compatible with the dependency requirements ``` - Backport rust-skia/rust-skia#916 to fix rust-skia/rust-skia#913 - Remaining relevant pr/issue: - google/skia#146 - https://gitlab.archlinux.org/archlinux/packaging/packages/neovide/-/issues/1 [1]: https://github.com/aimixsaka/rust-skia/tree/riscv-skia-bindings-0.68.0 [2]: https://github.com/neovide/neovide/blob/af9869bd6d8d3434b187e29f85032ee74e40b536/Cargo.toml#L59C68-L59C68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two scripts is platform-dependent and may fail if there are no prebuilt binaries for an unsupported platform. Making these steps optional makes building on those platforms easier, for they can use their own versions of toolchain (e.g. packages in a Linux distro).