Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasource/precomputed): check PNG image dimensions less strictly #654

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix(datasource/precomputed): check PNG image dimensions less strictly #654

merged 2 commits into from
Oct 22, 2024

Commits on Oct 21, 2024

  1. fix(datasource/precomputed): check PNG image dimensions less strictly 

    TensorStore encodes chunks of shape (x_size, y_size, z_size, c_size)
with width=x_size*y_size, height=z_size, while cloud-volume uses
width=x_size, height=y_size*z_size.

With this change, Neuroglancer will accept any width/height as long as
`width * height = x_size * y_size * s_zize`.  This loose checking was
already used for the JPEG format.

Fixes google/tensorstore#196
    @jbms
    jbms committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    40a5a83 View commit details
    Browse the repository at this point in the history

  2. fix(mypy): fix type annotations in json_wrappers.py

    @jbms
    jbms committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6f1386c View commit details
    Browse the repository at this point in the history