chore: Bump golangci-lint version to v1.57 #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
changed the title
This comment has been minimized.
This comment has been minimized.
jaqx0r
approved these changes
Mar 26, 2024
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing
golangci-lintGitHub workflow. It became failing after merging #813 (action).The golangci-lint workflow is failing because golangci-lint v1.52 was built with Go 1.19, so it's unfamiliar about Go 1.21 features that this repo is using.
Changes:
v1.57in.github/workflows/golangci-lint.yml. This version is the latest and is compatible with Go 1.21..golangci.ymlconfig and disable all new linters after v1.52. Likely, we will fix issues from them later.revivelinter about an unused parameter and fromgofmtabout an unsorted import.only-new-issues: false(default value) in.github/workflows/golangci-lint.yml.