Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keychain looks also into $HOME/.config/containers/auth.json #1977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kostola
Copy link

@kostola kostola commented Jul 16, 2024

Fixes #1976

Copy link

google-cla bot commented Jul 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@mepi262
Copy link

mepi262 commented Nov 14, 2024

@kostola
Have you sign a Contributor License Agreement?
#1977 (comment)

@kostola
Copy link
Author

kostola commented Nov 14, 2024

@kostola Have you sign a Contributor License Agreement?

@mepi262 yes, I signed the "Google Individual CLA"

edit: I did it after the bot commented, and in fact now that check passes without issues

@mepi262
Copy link

mepi262 commented Nov 15, 2024

@kostola
Thank you for your reply!

It seems that the GitHub actions is broken.
How would you like to push empty commit or close this pull request and reopen.

cf: https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

@kostola
Copy link
Author

kostola commented Nov 18, 2024

@mepi262 I rebased on top of latest main and then did also what you suggested here

cf: https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

but some workflows are still pending and not starting...idk where is the problem

@mepi262
Copy link

mepi262 commented Nov 18, 2024

@kostola

This workflow requires approval from a maintainer.

It seems that some pending workflows will be start when this pull request is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crane: auth get doesn't work with default keychain on Mac M1 + Podman
2 participants