Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crane: Add timestamp to flatten layer #1974

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nivbend
Copy link

@nivbend nivbend commented Jul 10, 2024

When flattening an image the blob's created field is the same as the original image's, while the flattened layer's created field is a zero timestamp. This makes it impossible to figure out when was the flattened image actually created and distinguish it from the original.

Set both fields to the current time.

Copy link

google-cla bot commented Jul 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nivbend
Copy link
Author

nivbend commented Aug 11, 2024

Fixes #1996.

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@nivbend
Copy link
Author

nivbend commented Nov 15, 2024

@imjasonh @thesayyn @jonjohnsonjr Would you have some time to review this minor fix? Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant