Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Crawler/filestore instances #202

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

peb-peb
Copy link
Contributor

@peb-peb peb-peb commented Jun 17, 2023

Notes

closes #201
ref to #153

@mxmssh @ZetaTwo

@peb-peb peb-peb changed the title Crawler/filestore instances refactor: Crawler/filestore instances Jun 17, 2023
@ZetaTwo
Copy link
Collaborator

ZetaTwo commented Jun 19, 2023

Looks good but there are conflicts. Please check.

@ZetaTwo
Copy link
Collaborator

ZetaTwo commented Jun 20, 2023

New merge conflicts

@peb-peb
Copy link
Contributor Author

peb-peb commented Jun 20, 2023

resolved!

@peb-peb
Copy link
Contributor Author

peb-peb commented Jun 20, 2023

I guess all the PRs would have conflicts as we merge each.

@ZetaTwo ZetaTwo merged commit 115f728 into google:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtasks: Implement crawl factory for FileStore resource.
2 participants