Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add TGLFInputs and TGLFNN #477

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add TGLFInputs and TGLFNN #477

wants to merge 16 commits into from

Conversation

theo-brown
Copy link
Collaborator

@theo-brown theo-brown commented Oct 30, 2024 •
edited
Loading

Add TGLFInputs class and TGLFNN model.
Note: completion depends on other work in progress in #476.

Remaining tasks:

  • Inherit from QuasilinearTransportModelInputs
  • Inherit from QuasilinearTransportModel
  • Move calculation of Coulomb logarithm, nu, etc to physics.py
  • Check normalisation, reference lengths, chiGB, etc

@theo-brown theo-brown mentioned this pull request Oct 30, 2024
Open
11 tasks
@theo-brown
Copy link
Collaborator Author

@lorenzozanisi could you lend a hand with checking the normalisations?

theo-brown
theo-brown commented Nov 21, 2024
View reviewed changes
torax/transport_model/tglf_based_transport_model.py
/ (CONSTANTS.qe * geo.B0) ** 2
* (Ti.face_value() * CONSTANTS.keV2J) ** 1.5
/ lref
)
Copy link
Collaborator Author

@theo-brown theo-brown Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this definition (chiGB) correct / consistent with TGLF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theo-brown @hamelphi