Support extension icons in ScriptCreateDialog #98914
Conversation
Attempt to grab the icon for a script type from an extension first, before falling back to the theme. This adds a method to option_button to allow the ScriptCreateDialog to set the max size of an item icon, so that it can set the size from the Editor Theme when reading the icon from extension.
fuzzybinary
force-pushed
the
gdextension-editor-settings
branch
from
4f8db25
to
bf3441c
Compare
fuzzybinary
force-pushed
the
gdextension-editor-settings
branch
from
2e22ce8
to
2d42776
Compare
fuzzybinary
force-pushed
the
gdextension-editor-settings
branch
from
2d42776
to
0a3fc27
Compare
AThousandShips
added
enhancement
topic:editor
bug
topic:gdextension
cherrypick:4.2
| Ref<Texture2D> language_icon = get_editor_theme_icon(ScriptServer::get_language(i)->get_type()); | ||
| // Check if the extension has an icon first | ||
| String script_type = ScriptServer::get_language(i)->get_type(); | ||
| Ref<Texture2D> language_icon = ed.extension_class_get_icon(script_type); | ||
| if (language_icon.is_valid()) { |
There was a problem hiding this comment.
It may not be easily doable with how the themes are set up, but don't you think a theme's script language icon should trump the extension's icon, if set explicitly?
There was a problem hiding this comment.
Yeah that's a good point.
Debugging through the code though, I'd have to check the return of get_editor_theme_icon to see if it's the same icon as default fallback. That's probably fine? I'll see if I can get it to work.
fuzzybinary
force-pushed
the
gdextension-editor-settings
branch
from
cccc520
to
4f207b1
Compare
|
@Ivorforce Updated so that theme takes precedence unless it returns the fallback icon, at which point it will ask the extension. |
| <param index="0" name="idx" type="int" /> | ||
| <param index="1" name="width" type="int" /> | ||
| <description> | ||
| Sets the maximum allowed width of the icon for the item at the given [param idx]. The height is adjusted according to the icon's ratio. |
There was a problem hiding this comment.
It might be nice to link to [method PopupMenu.set_item_icon_max_width] here to have cross coverage.
There was a problem hiding this comment.
🤔 You're probably right, but if that's the case we should probably add it to all the get_item_* methods yeah? I feel like it would be weird if this was the only one that cross linked...
There was a problem hiding this comment.
I guess that's true. Let's consider it outside the scope of this PR. We could make a follow-up issue about this, though i guess it's not all that important.
Attempt to grab the icon for a script type from an extension first, before falling back to the theme.
This adds a method to option_button to allow the ScriptCreateDialog to set the max size of an item icon, so that it can set the size from the Editor Theme when reading the icon from extension.
Example from Godot Dart:
Fixes #98800