OpenXR: Allow GDExtensions to implement _on_pre_draw_viewport() and _on_post_draw_viewport()
#98831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, it looks like PR #97151 also exposes |
fire
approved these changes
Nov 5, 2024
m4gr3d
approved these changes
Nov 5, 2024
AThousandShips
approved these changes
Nov 5, 2024
… `_on_post_draw_viewport()`
dsnopek
force-pushed
the
openxr-gdextension-pre-post-draw-viewport
branch
from
0bfd676
to
c72eb04
Compare
devloglogan
approved these changes
Nov 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
OpenXRExtensionWrapperExtensiondoesn't expose_on_pre_draw_viewport()and_on_post_draw_viewport(), despite exposing all other virtual methods.I don't think there's any reason for this, I think it was just an accidental omission.