-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy button to toast notification #98778
base: master
Are you sure you want to change the base?
Conversation
62c9946
to
5340c07
Compare
5340c07
to
1e65bb6
Compare
e9272d8
to
c5079b7
Compare
7fcddd9
to
397db7d
Compare
6b0145e
to
459b2cd
Compare
459b2cd
to
888fe19
Compare
Rebased with master. |
Had a thought after watching passivestar's twitter video about the toasts, he's using them for quick tool notifications instead of errors, do we think it might be a good idea to only show the copy button if the toast has a severity of warning/error? @KoBeWi @passivestar thoughts? Or have a way to specify if you want your |
@jaydensipe There are probably some cases where you'd want the copy button in regular message notifications if there's a script that shows you some interesting info like some scene stats and you don't want to outright add What I think might be interesting to consider in the future though is persistent toasts with action buttons: |
@passivestar Awesome, yeah that makes sense not to bloat the API for that, thanks for the input man. And yes buttons on the toasts would be sick |
Implements and closes godotengine/godot-proposals#11067 Bugsquad edit: use the GitHub magic words to link the proposal and auto-close when merged :)
Preview (edited)
Screen.Recording.2024-11-03.133504.mp4