Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy picking label bounds #98368

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix legacy picking label bounds #98368

merged 1 commit into from
Oct 25, 2024
+8 −12

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 20, 2024

Before
image

After
image

@KoBeWi KoBeWi added this to the 4.4 milestone Oct 20, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner October 20, 2024 21:08
AThousandShips
AThousandShips reviewed Oct 20, 2024
View reviewed changes
scene/gui/color_picker.cpp Outdated Show resolved Hide resolved
scene/gui/color_picker.cpp Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the color_picking_active_your_color_is_now_being_picked_please_pick_your_color branch from 9b7791b to 5b0f41a Compare October 20, 2024 21:24
bruvzg
bruvzg approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the issue.

Label is off center, and unnecessary huge, but it was like this before.

AThousandShips
AThousandShips approved these changes Oct 22, 2024
View reviewed changes
scene/gui/color_picker.cpp Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the color_picking_active_your_color_is_now_being_picked_please_pick_your_color branch from 5b0f41a to 82b53b1 Compare October 22, 2024 11:50
@clayjohn
Copy link
Member

Thank you!

@clayjohn clayjohn merged commit 6bd24cb into godotengine:master Oct 25, 2024
20 checks passed
@KoBeWi KoBeWi deleted the color_picking_active_your_color_is_now_being_picked_please_pick_your_color branch October 25, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @clayjohn @bruvzg @AThousandShips