Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizmo subscene visibility option #98351

Closed
wants to merge 8 commits into from

Conversation

LRJiao
Copy link

@LRJiao LRJiao commented Oct 20, 2024

Referencing #8220, this pull will create an option in view for both 2D and 3D scenes that will hide all gizmos of subscenes in addition to any current gizmo options selected.

Before toggle:
image
After: (Cylinder shape added in base scene for reference)
image

@LRJiao LRJiao requested review from a team as code owners October 20, 2024 00:31
@Chaosus
Copy link
Member

Chaosus commented Oct 20, 2024

Commits needs to be squashed (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html).

@Chaosus Chaosus added this to the 4.4 milestone Oct 20, 2024
@LRJiao LRJiao requested a review from a team as a code owner October 20, 2024 15:03
@LRJiao
Copy link
Author

LRJiao commented Oct 20, 2024

Commits needs to be squashed (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html).

Squashed, thank you for letting me know.

@fire
Copy link
Member

fire commented Oct 20, 2024

Gizmo subscene visibility option

This option is good feature wise, but I don't think the toggle should be in the Gizmos list. This toggle is not the same as the other toggles

What about putting Gizmo subscene visibility option beside the top level gizmos entry? Also use a check box.

@LRJiao
Copy link
Author

LRJiao commented Oct 20, 2024

Gizmo subscene visibility option

This option is good feature wise, but I don't think the toggle should be in the Gizmos list. This toggle is not the same as the other toggles

What about putting Gizmo subscene visibility option beside the top level gizmos entry? Also use a check box.

image
image

Adjusted to be a checkbox, similar to the 2D option.

@LRJiao LRJiao closed this Oct 20, 2024
@LRJiao LRJiao deleted the gizmo-visiblity branch October 20, 2024 22:25
@KoBeWi KoBeWi removed this from the 4.4 milestone Oct 20, 2024
@LRJiao
Copy link
Author

LRJiao commented Oct 21, 2024

Accidentally closed due to renaming, new PR is up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants