Unify filter feature and improve space management for EditorFileDialog #98022
+163
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feature is ready EDIT: but there is still that problem that was introduced before my PR: the makedir button is offscreen |
vPumpking
changed the title
|
There are some merge conflicts, could you rebase on top of |
|
sure, tomorrow that'll be done |
vPumpking
changed the title
vPumpking
force-pushed
the
editor_file_dialog_filter_master
branch
2 times, most recently
from
85e5526
to
dd6e8f7
Compare
AThousandShips
approved these changes
Nov 5, 2024
vPumpking
force-pushed
the
editor_file_dialog_filter_master
branch
from
dd6e8f7
to
f33415a
Compare
AThousandShips
approved these changes
Nov 22, 2024
Move buttons related to the file view on the container above so that they take less horizontal space and make search bar similar to the one in FileDialog
vPumpking
force-pushed
the
editor_file_dialog_filter_master
branch
from
f33415a
to
0542bcc
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move buttons related to the file view on the container above so that they take less horizontal space and make search bar similar to the one in FileDialog
This is part 2 of proposal godotengine/godot-proposals#9099
requested by @Calinou after #88673 (review)
see #97344 and #88673
replaces PR #97941 which was based on a forked branch instead of upstream