Add BoneAttachment3D.get_external_skeleton_path, deprecate get_external_skeleton
#96649
+40
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
BoneAttachment3D.get_external_skeleton_path, deprecate get_external_skeleton
|
Why only the get? Why not |
|
You're absolutely right! I'll update the setter too. |
Flynsarmy
force-pushed
the
get_external_skeleton_path
branch
from
e566e5d
to
790411a
Compare
Flynsarmy
force-pushed
the
get_external_skeleton_path
branch
2 times, most recently
from
d72e59b
to
c9c7d67
Compare
|
@TokageItLab I think this is ok, but I may have missed a conceptual problem. Can you review? |
TokageItLab
requested changes
Oct 7, 2024
Flynsarmy
force-pushed
the
get_external_skeleton_path
branch
from
7688ce3
to
77ba720
Compare
TokageItLab
requested changes
Oct 17, 2024
Flynsarmy
force-pushed
the
get_external_skeleton_path
branch
from
ee32966
to
0a7a9ad
Compare
…set_external_skeleton()
Flynsarmy
force-pushed
the
get_external_skeleton_path
branch
from
d1fec4d
to
1d7e852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves godotengine/godot-proposals#10670