-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Add a Preview Bake button for quick iteration with BakedLightmap #45237
base: 3.x
Are you sure you want to change the base?
Conversation
4878206
to
683ac6a
Compare
683ac6a
to
b74b490
Compare
If I understand it correctly, I can use preview bake if I want to in production (because real bakes will likely take too long on my hardware), this is just a suggestion/reminder? |
Yes, the preview bake is still saved and can be used in an exported project. That said, for your use case, I'd recommend you change the BakedLightmap node properties instead of relying on Preview Bake. |
b74b490
to
0de095c
Compare
0de095c
to
9977c32
Compare
I rebased and moved the
I'm not sure how to handle that part without accidentally exporting those preview bakes in the final PCK (if they weren't removed by the user). I think preview bake data could even be stored in |
71cb8d3
to
c58391c
Compare
677f1b6
to
5f35055
Compare
5f35055
to
51af3e7
Compare
When using the Preview Bake button instead of Bake Lightmaps, low quality settings will be used instead of settings from the BakedLightmap node. A node configuration warning will be displayed besides the BakedLightmap node to inform the user that the bake was done in preview mode. This preview bake warning is persisted to storage to make teamwork easier. This helps iterate quicker on a scene's lighting since you don't need to wait as much time to see results. On a simple test scene, Preview Bake was about 3 times faster than a "final" bake with the default BakedLightmap settings. The preview bake settings can be adjusted in the Project Settings.
51af3e7
to
916dd11
Compare
3.x
version of Add a Preview Bake button for quick iteration with LightmapGI #80518.When using the Preview Bake button instead of Bake Lightmaps, low quality settings will be used instead of settings from the BakedLightmap node. A node configuration warning will be displayed besides the BakedLightmap node to inform the user that the bake was done in preview mode. This preview bake warning is persisted to storage to make teamwork easier.
This helps iterate quicker on a scene's lighting since you don't need to wait as much time to see results.
On a simple test project, Preview Bake (0:00:38) was about 3 times faster than a "final" bake (0:01:48) with the default BakedLightmap settings.
By default, Preview Bake uses:
The preview bake settings above can be adjusted in the Project Settings. These are project settings so that different team members always use the same preview settings for consistency.
Comparison between Preview Bake and "final" bake
3.x
branch.