Add a test suite for Object #43583
Merged
Add a test suite for Object #43583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
|
Worth adding |
|
I guess let's merge once @Xrayez's suggestion is amended in, so that we have the base test available for other to add more tests when they fix bugs in Object. We should likely open an issue as a reminder that the test needs more content to cover the existing API (or leave the Object entry unchecked in #43440 with a call for more test cases). |
Calinou
force-pushed
the
test-add-object
branch
from
ce90020
to
2ead900
Compare
Calinou
force-pushed
the
test-add-object
branch
from
2ead900
to
e924bf9
Compare
Xrayez
approved these changes
Nov 20, 2020
akien-mga
approved these changes
Nov 20, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite sparse currently. Feel free to suggest additional tests to add.