Apply suggestions from code review

Co-authored-by: Rémi Verschelde <[email protected]>
godotengine · Nov 17, 2024 · 6540f16 · 6540f16
1 parent 88e4490
commit 6540f16
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/scene/resources/packed_scene.cpp b/scene/resources/packed_scene.cpp
@@ -1056,13 +1056,13 @@ Error SceneState::_parse_connections(Node *p_owner, Node *p_node, HashMap<String
 			const Node::Connection &c = F;
 
 			// Don't save connections that are not persistent.
-			if (!bool(c.flags & CONNECT_PERSIST)) {
+			if (!(c.flags & CONNECT_PERSIST)) {
 				continue;
 			}
 
 			// Don't include signals that are from scene instances
 			// (they are already saved in the scenes themselves).
-			if (bool(c.flags & CONNECT_INHERITED)) {
+			if (c.flags & CONNECT_INHERITED) {
 				continue;
 			}
 

diff --git a/tests/scene/test_packed_scene.h b/tests/scene/test_packed_scene.h
@@ -56,7 +56,7 @@ TEST_CASE("[PackedScene] Pack Scene and Retrieve State") {
 	memdelete(scene);
 }
 
-TEST_CASE("[PackedScene] Test That Correct Signals are Preserved when Packing Scene") {
+TEST_CASE("[PackedScene] Signals Preserved when Packing Scene") {
 	// Create main scene
 	// root
 	// `- sub_node (local)