Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant parentheses #777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

stewart-yu
Copy link

@stewart-yu stewart-yu commented May 9, 2023

What type of PR is this?

remove redundant parentheses

What this PR does / why we need it:

Remove redundant parentheses , useless

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@qmhu

@stewart-yu
Copy link
Author

@qmhu PTL

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-05-09 09:31
Git Version: 59ed43a

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-777-59ed43a docker pull gocrane/crane-agent:pr-777-59ed43a
dashboard:pr-777-59ed43a docker pull gocrane/dashboard:pr-777-59ed43a
metric-adapter:pr-777-59ed43a docker pull gocrane/metric-adapter:pr-777-59ed43a
craned:pr-777-59ed43a docker pull gocrane/craned:pr-777-59ed43a

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-777-59ed43a \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-777-59ed43a \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-777-59ed43a \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-777-59ed43a crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-777-59ed43a docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-777-59ed43a
dashboard:pr-777-59ed43a docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-777-59ed43a
metric-adapter:pr-777-59ed43a docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-777-59ed43a
craned:pr-777-59ed43a docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-777-59ed43a

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-777-59ed43a \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-777-59ed43a \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-777-59ed43a \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-777-59ed43a crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-777-59ed43a docker pull ghcr.io/gocrane/crane/crane-agent:pr-777-59ed43a
dashboard:pr-777-59ed43a docker pull ghcr.io/gocrane/crane/dashboard:pr-777-59ed43a
metric-adapter:pr-777-59ed43a docker pull ghcr.io/gocrane/crane/metric-adapter:pr-777-59ed43a
craned:pr-777-59ed43a docker pull ghcr.io/gocrane/crane/craned:pr-777-59ed43a

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-777-59ed43a \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-777-59ed43a \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-777-59ed43a \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-777-59ed43a crane/crane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant