Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InterfaceCustomUnmarshaler and test case to override interface type #450

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ozraru
Copy link
Contributor

@ozraru ozraru commented May 12, 2024

Close #449

  1. Add CustomInterfaceMarshaler and CustomInterfaceUnmarshaler.

There are Bytes(Un)Marshaler and Interface(Un)Marshaler interface.
But there is no Interface(Un)Marshaler in Custom(Un)Marshaler.

I want to use InterfaceUnmashaler as CustomUnmarshaler.

Renaming Custom(Un)marshaler to CustomBytes(Un)marshaler is good for describing function, but it breaks backward compatibility.

The linked issue has a use case and example.

  1. Add test cases to override interface type

Added test case corresponding to the example in the linked issue.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.91597% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 76.26%. Comparing base (4653a1b) to head (fe1b2f9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   76.02%   76.26%   +0.24%     
==========================================
  Files          13       13              
  Lines        4692     4790      +98     
==========================================
+ Hits         3567     3653      +86     
- Misses        866      875       +9     
- Partials      259      262       +3     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add InterfaceCustomUnmarshaler
2 participants