Add server command pre_files
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karoliineh Can you have a look so we can merge this? |
|
I'll just merge this because the GobPie features it was intended for aren't a priority right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #739.
This is on top of #391, because that's where #625 went. On
masterthe server always immediately preprocesses, parses and merges the file, so this isn't actually needed there.Even the full parsing is a bit excessive for this, but we need to do it because we use the same CIL parsing to collect all the files from preprocessor pragma locations. This could be optimized further by having a special parser for just those that ignores the actual C code, but that would be too premature for now.