Exclude Goblint stubs from YAML witnesses #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue identified by Freiburg.
The other "issue" with
(unsigned long )_ == 0ULor really any(unsigned long )arg == 0ULhas no easy improvement in Goblint. I thought it came from relation analysis because of the cast, but apparently it comes from base. Passing0into anvoid*argument performs no cast and simply puts the integer abstraction into the state for the pointer variable. The outputted invariant comes fromIntDomaininstead, which correctly inserts the cast.I thought about using
Cilfacade.makeBinOpwhich hopefully would be smarter about inserting casts for binary operators, but actually it's worse and turns it into(unsigned long )arg == (unsigned long )((void *)0)because of goblint/cil#162. If that is fixed, then we might have a neater way.