refactor(DashboardCreationController): update placeholder
#1109
Conversation
Deploying beaconchain with
|
| Latest commit: |
f642e06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://165a35d3.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-570-cookie-placeholder.beaconchain.pages.dev |
benji-bitfly
force-pushed
the
BEDS-570/cookie-placeholder-dashboardcreation
branch
4 times, most recently
from
d967a64
to
7bc10fc
Compare
benji-bitfly
changed the title
placeholderplaceholder
benji-bitfly
force-pushed
the
BEDS-570/cookie-placeholder-dashboardcreation
branch
4 times, most recently
from
48e3e50
to
1912cb3
Compare
|
np: |
…oard creation` When `user` starts the dashboard creation flow the user will have display the `input`field and start `user journey`. See: BEDS-570
…prove `ux` for `dashboard creation`
benji-bitfly
force-pushed
the
BEDS-570/cookie-placeholder-dashboardcreation
branch
from
1912cb3
to
f642e06
Compare
| @@ -78,7 +78,7 @@ function show( | |||
| } | |||
| network.value = forcedNetwork || currentNetwork.value | |||
| state.value = 'type' | |||
| name.value = isLoggedIn.value ? '' : 'cookie' | |||
| name.value = isLoggedIn.value ? '' : '' | |||
There was a problem hiding this comment.
I am not entirely sure on my own what this line does...which means that the whole feature needs refactoring...but plz never do things like this, because this line no is max-confusing
| name.value = isLoggedIn.value ? '' : '' |
(would exactly be the same)
| @@ -117,7 +117,7 @@ | |||
| "title": "Add a new dashboard", | |||
| "type": { | |||
| "accounts": "Accounts", | |||
| "placeholder": "Name", | |||
| "placeholder": "Enter dashboard name", | |||
There was a problem hiding this comment.
nice that you improve things along the way 💪.
But we are using placeholder as input labels.
See: https://www.deque.com/blog/accessible-forms-the-problem-with-placeholders/
Placeholder value should be an example of the things a user should input.
Maybe you come up with a different idea.
|
np: commit refactor(DashboardCreationController): remove In the See: BEDS-570 feat(DashboardCreationController): update placeholder for |
See: BEDS-570