Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move XIVLauncher.Common.Unix to XIVLauncher.Core #188

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

rankynbass
Copy link
Contributor

What it says on the tin. This will allow updates to wine, dxvk, etc without needing to modify xivlauncher.common. This should hopefully allow for quicker updates to XL.Core.

XIVLauncher.Common.Unix can be deleted from the main project, or just left there. It depends on XIVLauncher.Common, and nothing but XIVLauncher.Core depends on it.

@rankynbass rankynbass marked this pull request as ready for review October 27, 2024 22:26
@rankynbass rankynbass requested a review from a team as a code owner October 27, 2024 22:26
@Blooym Blooym requested a review from goaaats October 30, 2024 21:58
@rankynbass
Copy link
Contributor Author

Quick way to check that the files moved are exactly the same:

cd /tmp
git clone https://github.com/rankynbass/XIVLauncher.Core.git --branch move-xl-common-unix
git clone git clone https://github.com/goatcorp/FFXIVQuickLauncher.git
diff -r ./FFXIVQuickLauncher/src/XIVLauncher.Common.Unix  ./XIVLauncher.Core/src/XIVLauncher.Common.Unix

Should print out something like this:

23c23
<       <ProjectReference Include="..\XIVLauncher.Common\XIVLauncher.Common.csproj" />
---
>       <ProjectReference Include="..\..\lib\FFXIVQuickLauncher\src\XIVLauncher.Common\XIVLauncher.Common.csproj" />

@Blooym Blooym merged commit 980f3b9 into goatcorp:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants