-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EzWondrousTails v3.2.0.3 #5051
EzWondrousTails v3.2.0.3 #5051
Conversation
Went the wrong way on the scaling with the last update... oops. |
Outdated attemptBuilds failed, please check action output. Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 4 hours.
14 Needs (✅ All reviewed)
8 hidden needs (known safe NuGet packages).Show log - Review |
Man, your plugins are cursed. I hope goat can get to the bottom of this at some point. |
It's specifically using dalamud.NET.sdk inside library projects that's not working correctly in plogon. It used to be fine, but something changed with dalamudpackager (I assume) that's making it not play well anymore. Goat suggested in another post, that releasing a version of dalamud.NET.sdk that doesn't include dalamud packager, would make it suitable for use in library projects like KamiToolKit and KamiLib. |
With dalamud targets also having the same issue, and being depricated eventually, I would have to go back to defining all the project references manually, which I would very much rather not do given that we should be able to use nice things like dalamud.NET.sdk So I'll leave these failed builds here as a reminder of this issue, unless I am told by goat that they no longer plan to support library projects like KamiLib with dalamud.NET.sdk |
Head branch was pushed to by a user without write access
All builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
14 Needs (
|
Type | Name | Version | Reviewed by |
---|---|---|---|
Submodule | https://github.com/MidoriKami/KamiLib.git | 79ccadc60048b91b01bd06ddf9f13056595d9f9f | |
Submodule | https://github.com/MidoriKami/KamiToolKit.git | 2f907055d4fda5562999996286a8f39723512c62 | |
NuGet | NetStone | 1.1.1 | reiichi001 |
NuGet | HtmlAgilityPack | 1.11.46 | reiichi001 |
NuGet | Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork | 0.0.2 | reiichi001 |
NuGet | Microsoft.Build.Tasks.Git | 1.1.1 | goaaats |
Actually fixes incorrect scaling on border nodes in the book.