Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet the Den 1.0 #4986

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Quiet the Den 1.0 #4986

wants to merge 4 commits into from

Conversation

xorelcodes
Copy link

Frist plugin, let me know if anything needs to be changed!

@bleatbot bleatbot enabled auto-merge (squash) November 20, 2024 06:33
@philpax philpax added the new plugin This is a new plugin. label Nov 20, 2024
@philpax
Copy link
Contributor

philpax commented Nov 20, 2024

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 20, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 1 hours.

Name Commit Status
😰 QuietTheDen [testing-live] adeb1d3 Build system error: DalamudPackager output not found, make sure it is installed
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 20, 2024
@philpax
Copy link
Contributor

philpax commented Nov 20, 2024

Hi! Thanks for submitting your plugin - new plugins will take some time to get to as we're clearing out the updates for API11, but we hope to have you sorted out soon 🙂

We're looking into why your build failed and will hopefully have a fix for you soon.

@xorelcodes
Copy link
Author

Did a look after realizing maybe putting this all together at 1am wasn't smart, noticed I didn't update the csproj file so I went ahead and did that and found a few things to cleanup like the sample namespace still being used. Didn't want to just do a different pull request but I have a new commit id here if this helps

272365883b313022189374415e8e0cd44a6f10f1

Thanks!

@philpax
Copy link
Contributor

philpax commented Nov 20, 2024

You can edit the manifest in this PR to change the commit ID; an easy way to do that is from within GitHub itself, where you can edit individual files. Feel free to update the PR 🙂

auto-merge was automatically disabled November 20, 2024 13:44

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 20, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
😰 QuietTheDen [testing-live] 2723658 Build system error: DalamudPackager output not found, make sure it is installed
Show log - Review

@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ QuietDen [testing-live] 2723658 v0.0.1.0 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-mid Diff for this PR is mid-sized. and removed build failed This plugin failed to build. labels Nov 20, 2024
@philpax
Copy link
Contributor

philpax commented Nov 20, 2024

Ah, of course, I keep forgetting about that. Well diagnosed!

@xorelcodes
Copy link
Author

It's such a simple thing, but i was like...something looks off lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new plugin This is a new plugin. size-mid Diff for this PR is mid-sized.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants