Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurrencySpender Release #4942

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

CurrencySpender Release #4942

wants to merge 5 commits into from

Conversation

Blackcatz1911
Copy link

A plugin to display where/how to spend your currencies.
Currently supported:

  • GC Seals
  • Peotics
  • Wolf Marks
  • Tomestone of Aesthetics

/cur To open the main window.

@Blackcatz1911
CurrencySpender Release
a19abfd 
CurrencySpender Release
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024 •
edited
Loading

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@bleatbot bleatbot enabled auto-merge (squash) November 18, 2024 17:02
@reiichi001
Copy link
Contributor

bleatbot, approve

@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Nov 18, 2024
@reiichi001
Copy link
Contributor

This plugin is now in the plugin review queue; we hope to get back to you soon! It may take a while as we are still working towards a public release of Dalamud for FFXIV Patch 7.1 and API 11 plugin updates.

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
❌ CurrencySpender [testing-live] 0d2958b Build failed (Diff)
2 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/NightmareXIV/ECommons.git 974a0ef35536b7f0a10a278539f7136d6966baa3 ⚠️ NEW
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. and removed pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Nov 18, 2024
@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Nov 18, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
🖼️ CurrencySpender [testing-live] d8b24c9 Missing icon in images/ build output!
Show log - Review

@bleatbot bleatbot added need icon This plugin needs an icon. and removed build failed This plugin failed to build. pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Nov 18, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
❌ CurrencySpender [testing-live] 0d2958b Build failed (Diff)
2 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/NightmareXIV/ECommons.git 974a0ef35536b7f0a10a278539f7136d6966baa3 ⚠️ NEW
1 hidden need (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added build failed This plugin failed to build. and removed need icon This plugin needs an icon. labels Nov 18, 2024
auto-merge was automatically disabled November 18, 2024 21:00

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ CurrencySpender [testing-live] d8b24c9 v0.0.1.0 - Repo (New plugin)
9 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/NightmareXIV/ECommons.git 974a0ef35536b7f0a10a278539f7136d6966baa3 ⚠️ NEW
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Nov 18, 2024
@reiichi001 reiichi001 added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Nov 18, 2024
@reiichi001 reiichi001 self-assigned this Nov 18, 2024
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ CurrencySpender [testing-live] 77e252e v0.0.2.0 - Repo (New plugin)
10 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/Critical-Impact/AllaganLib.git 2636e44092516b19e1692ed3ec856b1aeb60215a ⚠️ NEW
Submodule https://github.com/NightmareXIV/ECommons.git 974a0ef35536b7f0a10a278539f7136d6966baa3 ⚠️ NEW
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reiichi001 reiichi001

Labels
new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackcatz1911 @bleatbot @reiichi001