Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DailyDuty v5.2.0.3 #4928

Merged
merged 3 commits into from
Nov 24, 2024
Merged

DailyDuty v5.2.0.3 #4928

merged 3 commits into from
Nov 24, 2024

Conversation

MidoriKami
Copy link
Contributor

@MidoriKami MidoriKami commented Nov 18, 2024

Remove Teleporter Plugin dependency.
Fix Raids Modules not updating to new duties.
Fix Jumbo Cactpot time calculation.
Fix plugin opening config window on load.

@bleatbot bleatbot enabled auto-merge (squash) November 18, 2024 05:02
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 2 hours.

Name Commit Status
DailyDuty [stable] 4d04b14 Build failed (Diff)
14 Needs (⚠️ 1 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib bd70e791bd1d1afa84e3fb9ef12c559c52ded241 ⚠️ Upd. from 427d7919b1f5a154daf6815216086604f804f1b5
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 18, 2024
@philpax
Copy link
Contributor

philpax commented Nov 18, 2024

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 18, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
DailyDuty [stable] 4d04b14 Build failed (Diff)
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib bd70e791bd1d1afa84e3fb9ef12c559c52ded241 reiichi001
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@philpax
Copy link
Contributor

philpax commented Nov 18, 2024

@goaaats looks like this one will need your intervention as well

@MidoriKami
Copy link
Contributor Author

MidoriKami commented Nov 18, 2024

DailyDuty, NoTankYou, and CurrencyAlert, all use the same combination of KamiLib, KamiToolkit, and main plugin code. It's very odd to me that it works sometimes, but not others.

I won't really have any time until this upcoming weekend to mess with things, so ideally by then we can work something out.

@reiichi001
Copy link
Contributor

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 21, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
DailyDuty [stable] 4d04b14 Build failed (Diff)
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib bd70e791bd1d1afa84e3fb9ef12c559c52ded241 reiichi001
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@MidoriKami
Copy link
Contributor Author

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 21, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
DailyDuty [stable] 4d04b14 Build failed (Diff)
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib bd70e791bd1d1afa84e3fb9ef12c559c52ded241 reiichi001
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001
Copy link
Contributor

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 23, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
DailyDuty [stable] 4d04b14 Build failed (Diff)
14 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib bd70e791bd1d1afa84e3fb9ef12c559c52ded241 reiichi001
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

auto-merge was automatically disabled November 24, 2024 21:29

Head branch was pushed to by a user without write access

@MidoriKami MidoriKami changed the title DailyDuty v5.2.0.1 DailyDuty v5.2.0.2 Nov 24, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 24, 2024

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ DailyDuty [stable] c26d923 v5.2.0.2 - Diff (17 lines, prev. 5.2.0.0) - Semantic
14 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib 79ccadc60048b91b01bd06ddf9f13056595d9f9f ⚠️ Upd. from bd70e791bd1d1afa84e3fb9ef12c559c52ded241
Submodule https://github.com/MidoriKami/KamiToolKit.git 2f907055d4fda5562999996286a8f39723512c62 ⚠️ Upd. from 8027b76b17f649ccd379e14598858d60dd6a9d42
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Nov 24, 2024
@MidoriKami MidoriKami changed the title DailyDuty v5.2.0.2 DailyDuty v5.2.0.3 Nov 24, 2024
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ DailyDuty [stable] df72982 v5.2.0.3 - Diff (30 lines, prev. 5.2.0.0) - Semantic
14 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib 79ccadc60048b91b01bd06ddf9f13056595d9f9f ⚠️ Upd. from bd70e791bd1d1afa84e3fb9ef12c559c52ded241
Submodule https://github.com/MidoriKami/KamiToolKit.git 2f907055d4fda5562999996286a8f39723512c62 ⚠️ Upd. from 8027b76b17f649ccd379e14598858d60dd6a9d42
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 merged commit 7dcec6e into goatcorp:main Nov 24, 2024
2 checks passed
@MidoriKami MidoriKami deleted the patch-82 branch November 24, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small Diff for this PR is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants