Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deleting NSMutableURLRequest headers #346

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Support deleting NSMutableURLRequest headers #346

merged 1 commit into from
Nov 14, 2023

Conversation

triplef
Copy link
Member

@triplef triplef commented Nov 14, 2023

Calling setValue:forHTTPHeaderField: with a nil value deletes the header on Apple platforms.

@triplef triplef requested a review from rfm as a code owner November 14, 2023 21:41
rfm
rfm reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, but please could you also update the documentation (NSURLRequst.h) to note that setting a nil value removes the header.

@triplef triplef force-pushed the fix-url-request-header-delete branch from 57c2522 to f0ddb48 Compare November 14, 2023 21:59
@triplef triplef force-pushed the fix-url-request-header-delete branch from f0ddb48 to 0e916fd Compare November 14, 2023 22:00
@triplef
Copy link
Member Author

triplef commented Nov 14, 2023

Yes good point, I updated the documentation.

@triplef triplef merged commit fd7f11a into master Nov 14, 2023
2 of 9 checks passed
@triplef triplef deleted the fix-url-request-header-delete branch November 14, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfm rfm rfm left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triplef @rfm