Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5: debian distros based on bullseye no longer require qt5-default #266

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

marcidy
Copy link
Contributor

@marcidy marcidy commented Aug 27, 2021

Debian stable as of bullseye no longer has a qt5-default package, as
qt4 support was removed and qt5 is default. Distros based on debian
will not have this package.

Relates to gnuradio/pybombs#555

On Debian 11 (bullseye), I ran the installation with the updated qt5 recipe and everything installed fine, and I was able to run gnuradio-companion. I'm not sure if there are other tests to run to confirm, apologies, quite new to gnuradio.

Note answer here for Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1926802

Honestly, I'm not clear if this fix is really correct, because i think the recipe needs to be sync'd to the Debian 11 epoch. Pre Debian 11, the old recipe works, where-as post Debian 11, the old recipe wont.

Fixes gnuradio/pybombs#555

@willcode
Copy link
Member

The GNU Radio CI Docker images for Debian 10 and 11 do not install qt5-default, but they do install

libqwt-qt5-6
python3-pyqt5
libqwt-qt5-dev
qtbase5-dev
pyqt5-dev-tools

so some more research is needed. Some of these are in other recipes (e.g., qwt6.lwr). At least qtbase5-dev is going to be required, maybe more.

@marcidy
Copy link
Contributor Author

marcidy commented Aug 27, 2021

qtbase5-dev is resolved when installing libqt5opengl5-dev, do you want it an explicit dep, or is that OK? Takes no time to add it, just want to know your preference.

$ apt-cache show libqt5opengl5-dev
Package: libqt5opengl5-dev
Source: qtbase-opensource-src
Version: 5.15.2+dfsg-9
Installed-Size: 318
Maintainer: Debian Qt/KDE Maintainers <[email protected]>
Architecture: amd64
Replaces: qtbase5-dev (<< 5.11.3+dfsg-4~)
Provides: libqt5opengl5-desktop-dev (= 5.15.2+dfsg-9)
Depends: libqt5opengl5 (= 5.15.2+dfsg-9), qtbase5-dev (= 5.15.2+dfsg-9)
Breaks: qtbase5-dev (<< 5.11.3+dfsg-4~)

pyqt5.lwr covers pyqt5-dev, pyqt5-dev-tools, python-pyqt5

category: baseline
configure: python configure.py --confirm-license -b $prefix/bin -d $prefix/lib/python2.6/site-packages/ -v $prefix/share/sip/
depends:
- python
- sip
- qt5
inherit: autoconf
install_like: qt5
satisfy:
  deb: ( pyqt5-dev >= 5.3.2 ) && ( pyqt5-dev-tools >= 5.3.2 ) && python-pyqt5
  rpm: (python-qt5 || python2-qt5) && python-qt5-devel
  pacman: python-pyqt5
  port: py27-qt5 >= 5.7.1
  portage: dev-python/PyQt5 >= 5.7.1
satisfy@python3:
  deb: python3-pyqt5
  rpm: python3-qt5 && python3-qt5-devel
source: wget+https://sourceforge.net/projects/pyqt/files/PyQt5/PyQt-5.6/PyQt5_gpl-5.6.tar.gz

As you noted, libqwt-qt5-6 is handled via libqwt-qt5-dev in qwt6.lwr

$ apt-cache show libqwt-qt5-dev
Package: libqwt-qt5-dev
Source: qwt
Version: 6.1.4-2
Installed-Size: 573
Maintainer: Gudjon I. Gudjonsson <[email protected]>
Architecture: amd64
Replaces: libqwt-headers (<< 6.1.4-1.1~)
Depends: libqwt-qt5-6 (= 6.1.4-2), libc6 (>= 2.14), libgcc-s1 (>= 3.0), libqt5core5a (>= 5.15.1), libqt5designer5 (>= 5.6.0~beta), libqt5gui5 (>= 5.0.2) | libqt5gui5-gles (>= 5.0.2), libqt5widgets5 (>= 5.0.2), libstdc++6 (>= 5)

@willcode
Copy link
Member

We should probably have qtbase5-dev, to be more like the other sources in the file. Really, the PyBOMBS deps just need to be "good enough" and are probably missing all kinds of things that are being provided by the deb/rpm dep chains.

With the release of Bullseye (Debian 11), qt5 is the default, and qt4 is
not supported.  The qt5-default package is no longer in the repos, so
qtbase5-dev is added instead of qt5-default as the dependency.

Signed-off-by: Matt Arcidy <[email protected]>
@marcidy
Copy link
Contributor Author

marcidy commented Aug 28, 2021

Done!

@willcode willcode merged commit de6de0d into gnuradio:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERROR] Package has no install method: qt5
2 participants