-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup makefile and lock gno dependencies #164
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
✅ Deploy Preview for gno-by-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9c2d93a
to
dcae40b
Compare
Signed-off-by: gfanton <[email protected]>
dcae40b
to
aa5949d
Compare
Signed-off-by: gfanton <[email protected]>
uses: ./.github/workflows/test.yaml | ||
generate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused how we didn't have this CI before 🤦♂️
.github/dependabot.yaml
Outdated
schedule: | ||
interval: "daily" | ||
target-branch: "main" | ||
versioning-strategy: "lockfile-only" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not available for Go, so it doesn't have any effect:
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy
.github/dependabot.yaml
Outdated
@@ -1,5 +1,13 @@ | |||
version: 2 | |||
updates: | |||
- package-ecosystem: "gomod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add dependabot groups?
.github/dependabot.yaml
Outdated
@@ -1,5 +1,13 @@ | |||
version: 2 | |||
updates: | |||
- package-ecosystem: "gomod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how gno will be updated as a dependency, since we don't do releases yet 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't know it was not working on pseudo-release, I will remove dependabot for now
Signed-off-by: gfanton <[email protected]>
@gfanton |
This PR accomplishes the following:
gno
version by using ago.mod
for consistency and continuous integration against maingno
repository through Dependabot.Makefile
.Makefile
the entry point for all commands by incorporatingyarn script
commands into it.generate
command