Commits on Mar 29, 2023

1. glusterd: avoid starting the same brick twice …

   There was a race in glusterd code that could cause that two threads
   start the same brick at the same time. One of the bricks will fail
   because it will detect the other brick running. Depending on which
   brick fails, glusterd will report a start failure and mark the brick
   as stopped even if it's running.
   
   The problem is caused by an attempt to connect to a brick that's being
   started by another thread. If the brick is not fully initialized, it
   will refuse all connection attempts. When this happens, glusterd receives
   a disconnection notification, which forcibly marks the brick as stopped.
   
   Now, if another attempt to start the same brick happens, it will believe
   that the brick is stopped and it will start it again. If this happens
   very soon after the first start attempt, the checks done to see if the
   brick is already running will still fail, triggering the start of the
   brick process again. One of the bricks will fail to initialize and will
   report an error. If the failed one is processed by glusterd in the
   second place, the brick will be marked as stopped, even though the
   process is actually there and working.
   
   Fixes: gluster#4080
   Signed-off-by: Xavi Hernandez <[email protected]>

   

   xhernandez committed Mar 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 12bca84
   • Browse repository at this point

   Copy the full SHA

   12bca84 View commit details

   Browse the repository at this point in the history