Add simple Logstash adapter

[maxekman]

This adds a simpler version of the Logstash UDP adapter created in github.com/gliderlabs/logspout.

[progrium]

What's this?

[progrium]

I see, it's a global. Maybe set this up as a field of the adapter object and do this in its constructor.

[maxekman]

@progrium Updated with more Docker fields, similar to the fields in https://github.com/digital-wonderland/docker-logstash-forwarder.

[progrium]

Why do you think JSON+UDP should be the canonical way logspout should send logs to logstash?

[maxekman]

I think UPD should be the default because it's faster for streaming logs, and there can be a lot from some docker containers. For more info: https://github.com/dwbutler/logstash-logger#what-type-of-logger-should-i-use

[progrium]

Maybe it should just be called a JSON adapter then?

[progrium]

Does this satisfy your use?
#65

[maxekman]

I think your JSON adapter is a pretty cool implementation, but I would like to have both! My implementation is focused on performance as this is more important in our use case.

[progrium]

I recommend putting this adapter in its own repo and building logspout
against it. Others can use it if they want but you can continue to maintain
it.

On Friday, March 27, 2015, Max Persson [email protected] wrote:

I think your JSON adapter is a pretty cool implementation, but I would
like to have both! My implementation is focused on performance as this is
more important in our use case.

—
Reply to this email directly or view it on GitHub
#64 (comment).

Jeff Lindsay
http://progrium.com

[maxekman]

Sure, are there any guidelines on how to do that?

[progrium]

The repo name should be prefixed with logspout- and have a descriptive name, so I imagine this would be logspout-logstash-json on your github account. The go package can still be called logstash or anything, it's not relevant. You can put the package anywhere in there, but I recommend at the root. This way, you can just add a line to modules.go imports:

    _ "github.com/maxpersson/logspout-logstash-json"

Depending on how often you might change it and to what degree, I recommend versioning/tagging with gopkg.in conventions. This way people can use that for pinning if they wish.

[maxekman]

Will this be added to gliderlabs/logspout/modules.go or to my own fork?

[progrium]

Anybody's fork. We'll list it as a third-party module in the readme.

[maxekman]

What I meant was when using logspout; will I be able to run your container with my module referenced in it, or would I create and push my own container from my own fork using my adapter?

[progrium]

For now you need your own container fork. Eventually you can dynamically load modules at container boot.

[maxekman]

Ok, thanks for the info.

[progrium]

This might make it easier for you: https://github.com/gliderlabs/logspout/pull/66/files

[maxekman]

I created a custom module instead, available here https://github.com/looplab/logspout-logstash. Closing this PR.