Consistent returns for read_variable_declaration
#1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genintho
commented
Nov 25, 2024
| } else { | ||
| this.expect([",", ";", "="]); | ||
| return result(propName, null, nullable, type, attrs || []); |
There was a problem hiding this comment.
here, readonly is not passed.
genintho
commented
Nov 25, 2024
| "kind": "property", | ||
| "name": Identifier { | ||
| "kind": "identifier", | ||
| "name": "onst", | ||
| }, | ||
| "nullable": Name { |
There was a problem hiding this comment.
The snapshot show that what was set was incorrect: instead of a boolean value we had some objects.
cseufert
reviewed
Nov 26, 2024
src/parser/class.js
Outdated
| type, | ||
| attrs || [], | ||
| ); | ||
| value = this.next().read_expr(); | ||
| } else { | ||
| this.expect([",", ";", "="]); |
There was a problem hiding this comment.
I think we need to drop the "=" in th eexpect, we already handled that with the previous if condition.
Suggested change
| this.expect([",", ";", "="]); | |
| this.expect([",", ";"]); |
There was a problem hiding this comment.
"," and ";" are handled by the first if.
I think this line is here to show an error message indicating that we expect one of those 3 things.
I figured this out while working on adding support for property hooks.
cseufert
requested changes
Nov 26, 2024
|
I do not have permission to merge 😄 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding support for property hooks, I realized that the function parsing class property does not always call the "return" function with the same parameters: in some instance, the parameter
readonlyis not being passed done.This PR fix that by having 1 call to return despite multiple branches in the logic.