Upgrade to Ruby 2.7.8 → 3.0.7, Rails 6.0 → 6.1 #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see it mentioned, but did you run the Rails specific update task and then make any changes we would need to based on the 6.0 -> 6.1 breaking changes? |
|
Oh thanks, I didn't know about that! Have pushed those updates, and some test fixes. |
BatedUrGonnaDie
approved these changes
Oct 18, 2024
| # | ||
| # config.time_zone = "Central Time (US & Canada)" | ||
| # config.eager_load_paths << Rails.root.join("extras") | ||
|
|
||
| # Initialize configuration defaults for originally generated Rails version. | ||
| config.load_defaults 6.0 |
There was a problem hiding this comment.
We should load the defaults for 6.1 now (see other comment).
| @@ -0,0 +1,67 @@ | |||
| # Be sure to restart your server when you modify this file. | |||
There was a problem hiding this comment.
This file is only needed to enable 6.1 defaults one at a time. If possible can you test each one and then remove this and enable the 6.1 defaults?
There was a problem hiding this comment.
Want to ship this and let it run for a bit first, so we have a smaller search space for any issues we hit. Then will swap over the defaults one by one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a tangled mess of a mass update to Rails 7, but had no confidence in its correctness, so taking it slow making incremental updates instead.
This branch's goal is only to update Ruby, but it seems Rails needs a bump to reasonably support that as well. There were a few explicit updates required along with that, and the rest of the gem updates were caused (so required) directly by the
bundle update rails ...command.The migrations were generated by Authie, which required them for its own upgrade.