add docker-credential-helper to gitpot-cli

[tbutter]

Description

This allows you to use gitlab.com credentials for docker using gitpod-cli.
It's currently only working for gitlab and I am looking for feedback if that's the right way to do it before adding other providers.

Requires an additional file in the workspace docker image:
/usr/bin/docker-credential-gp

#!/bin/bash
gp docker-credential-helper "$@"

and in /home/gitpod/.docker/config.json

{
        "auths": {},
        "credsStore": "gp"
}

How to test

open a private gitlab repo context and then use docker pull to pull a private image from the gitlab registry.

Release Notes

Documentation

not sure

[roboquat]

@tbutter: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csweichel]

Thanks @tbutter, that makes a ton of sense to me.

Re integration: we have a process in supervisor already which establishes symlinks, e.g. for /usr/bin/gp. We could use that very process to establish a symlink for /usr/bin/docker-credential-gp. Further, we could consider creating/patching the ~/.docker/config.json file on supervisor (or docker-up?) startup.

[gtsiolis]

Thanks for contributing, @tbutter! 🧡

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tbutter]

@csweichel Thanks. I could not figure out a way to test the supervisor code locally/in gitpod. Are there any docs on how to do it?
@meysholdt Can you send me the CLA to sign?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tbutter]

Thanks for contributing, @tbutter! 🧡

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

Is there anything I can do to support the CLA process?

[gtsiolis]

Is there anything I can do to support the CLA process?

@tbutter Sorry this is taking longer than usual but please bare with us as most of the company is currently at our offsite, we'll get back to this next week. 🎗️

[meysholdt]

hi @tbutter! Can you send an email with your real name to [email protected]? Then I can email you the CLA. Apologies for the late response - as George said, we all were at a company offsite last week.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[axonasif]

Can we use the HOME variable instead of hardcoding the path here?

[tbutter]

I am not sure if its set at that stage and have no way to test it.
All other install functions in supervisor.go also hardcode the path.

[axonasif]

Hmm, np. Other than that, please sign the CLA fast so that we can get this merged! 🚀 😄

[tbutter]

I signed the CLA on March, 31st.

[tbutter]

@axonasif what can I help to bring this MR forward?
the helper works. i assume the supervisor works too (but can't test locally)

[axonasif]

It also looks like we can't reopen the PR anymore. Can you please create a new one?

[shaal]

I have a similar issue - shaal/DrupalPod#87
I want to be able to use the same git access provided by gp credential-helper inside docker-compose container (ddev), so I can clone private projects, and run composer just like I can do in Gitpod.