Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump terminal-table to 3.0.2 #894

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

anna328p
Copy link

Prevents a dependency conflict with steep.

Prevents a dependency conflict with `steep`.
@jabenninghoff
Copy link

jabenninghoff commented Aug 9, 2024

+1 on this PR, this is also causing a dependency conflict with the version of rubocop needed for the currently used version of ruby (3.3.4). Can this be merged?

@@ -26,7 +26,7 @@ Gem::Specification.new do |s|

s.add_dependency("mercenary", "~> 0.3")
s.add_dependency("nokogiri", ">= 1.13.6", "< 2.0")
s.add_dependency("terminal-table", "~> 1.4")
s.add_dependency("terminal-table", "~> 3.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might prefer something like >= 1.4, <4 for now unless our use is broken between these versions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants